-
Notifications
You must be signed in to change notification settings - Fork 2
Ms/scrum 130 project deployment CI/CD #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MasahisaSekita
merged 46 commits into
develop
from
ms/Scrun-130-Project-Deployment-dockerfiles
Mar 23, 2025
Merged
Ms/scrum 130 project deployment CI/CD #79
MasahisaSekita
merged 46 commits into
develop
from
ms/Scrun-130-Project-Deployment-dockerfiles
Mar 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-lann
reviewed
Mar 20, 2025
course-matrix/backend/Dockerfile
Outdated
| echo "PORT=8081" >> .env && \ | ||
| echo "CLIENT_APP_URL=http://localhost:5173" >> .env && \ | ||
| echo "DATABASE_URL=https://pmiihreibkvcruwhjvpj.supabase.co" >> .env && \ | ||
| echo "DATABASE_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZSIsInJlZiI6InBtaWlocmVpYmt2Y3J1d2hqdnBqIiwicm9sZSI6InNlcnZpY2Vfcm9sZSIsImlhdCI6MTczODE3NTMyNiwiZXhwIjoyMDUzNzUxMzI2fQ.hZ1goNXMKMfYDPyihsM5lZTh4i30BcEWMkJ7uJy1ddA" >> .env && \ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you see if there is a way to not have the environment variables hardcoded?
kevin-lann
approved these changes
Mar 23, 2025
Contributor
kevin-lann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Env vars are good now. Looks ready to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added CI/CD to our application. Now whenever a new push is made that passes all unit tests it is automatically redeployed onto our vm.
SCRUM-130
Type of change
Checklist: